Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kodi: downgrades kodiPlugin.joystick to compatible version 1.3.2 #30790

Merged
merged 1 commit into from Nov 28, 2017

Conversation

spiderbit
Copy link

@spiderbit spiderbit commented Oct 25, 2017

Motivation for this change

Get kodi joystick support running with kodi 17.x

Use it in kodi 17.09 testet it also in master on another pc.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [ x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@spiderbit
Copy link
Author

spiderbit commented Oct 25, 2017

fixes #25490
I am not shure if kodi can access the plugins from the system path without linking them kodi's home directory plugin path, but that would be a separate more generic plugin issue.

at least if you link the created plugin directory with that version to your home plugin path and you have the original skin in kodi (so you can open the input configuration dialog in kodi) and you setup the buttons through that dialog it works. while 1.3.6 has a incompatible abi, 1.3.2 is the correct version that is compatilbe with Krypton!

technicaly it should work with 17.03 too, could not test it, didnt realise that I had to use the original kodi skin to be able to use the joystick configuration dialog, but than it should work. Can't see that patch have any negative side effects, so depending on your policy I would suggest merge it with the 17.03 branch too.

@wizeman
Copy link
Member

wizeman commented Nov 18, 2017

I can confirm this commit also makes a Sony DualShock 4 v2 controller work with Kodi.

BTW, you don't need to symlink the plugin manually into your home directory.
If you want to enable the joystick plugin in Kodi you can simply add the following to your /etc/nixos/configuration.nix :

  nixpkgs.config = {
    kodi = {
      enableJoystick = true;
    };
  };

After doing nixos-rebuild switch to activate your new configuration (and after removing the symlink you created manually) it should just work. However, if you have installed Kodi with nix-env -i, then probably you'd need to upgrade Kodi with nix-env -u (I'm not entirely sure because I don't use nix-env).

@spiderbit
Copy link
Author

spiderbit commented Nov 27, 2017

When I look at the continuous-integration tests that did fail it looks like that has nothing to do with my package.

It looks more that whatever tree it tries uses kodi itself seem to fail to compile:

cannot build derivation ‘/nix/store/r7syh7mfdm9f65zyrc3jg89zg0rw627z-kodi-plugin-peripheral.joystick-1.3.2.drv’: 1 dependencies couldn't be built

Why does a bug in kodi compilation unrelated to my package stop the merge of my changes?

I commited it over a month ago, @wizeman agrees that it fixes joystick support for kodi. I don't really get why its so complicated to merge than bugfix.

Its pretty streight forward, the 1.3.7 peripheral.joystick package is defect cause incompatible, switching to 1.3.2 fixes that problem, there are no regressions, so merge it!

If you have buggy tests or kodi is not building correctly fix it, but dont block this merge with things that are unrelated to this bugfix.

@wizeman wizeman merged commit 9249dc6 into NixOS:master Nov 28, 2017
@wizeman
Copy link
Member

wizeman commented Nov 28, 2017

Thanks!

@wizeman
Copy link
Member

wizeman commented Nov 28, 2017

Backported to 17.09.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants