Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samba: 4.6.8 -> 4.6.11 to address CVEs CVE-2017-14746 & CVE-2017-15275 #31905

Merged
merged 1 commit into from Nov 21, 2017
Merged

samba: 4.6.8 -> 4.6.11 to address CVEs CVE-2017-14746 & CVE-2017-15275 #31905

merged 1 commit into from Nov 21, 2017

Conversation

andir
Copy link
Member

@andir andir commented Nov 21, 2017

More details at [1] & [2]

[1] https://www.samba.org/samba/security/CVE-2017-15275.html
[2] https://www.samba.org/samba/security/CVE-2017-14746.html

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from fpletz November 21, 2017 17:16
vcunat
vcunat approved these changes Nov 21, 2017
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

samba attribute builds for me. All version bumps in-between only contain bugfixes (and security fixes), so it seems safe.

@vcunat vcunat added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 21, 2017
@vcunat
Copy link
Member

vcunat commented Nov 21, 2017

BTW, sambaFull fails the same as before this PR.

@vcunat vcunat merged commit 45f0c0b into NixOS:master Nov 21, 2017
vcunat added a commit that referenced this pull request Nov 21, 2017
@vcunat
Merge #31905: samba: security 4.6.8 -> 4.6.11
c024f0b
@andir andir deleted the fix-samba-4.6.11 branch November 22, 2017 08:25
@vcunat vcunat removed the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 25, 2017
vcunat added a commit that referenced this pull request Nov 28, 2017
@vcunat
Merge #31905: samba: security 4.6.8 -> 4.6.11
043cbe5 
(cherry picked from commit c024f0b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andir @vcunat @Mic92 @GrahamcOfBorg