Adding enable_elasticity option to pool configuration #3019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaiser
force-pushed
the
pool_elasticity
branch
2 times, most recently
from
a15c9ff
to
55ea677
Compare
- fixing performance problem related to get_used_processing_units() for non-elastic pools
hkaiser
force-pushed
the
pool_elasticity
branch
from
55ea677
to
5a082bb
Compare
biddisco
reviewed
Nov 23, 2017
| @@ -14,7 +14,8 @@ namespace hpx { namespace threads { namespace policies | |||
| do_background_work = 0x1, | |||
| reduce_thread_priority = 0x02, | |||
| delay_exit = 0x04, | |||
| fast_idle_mode = 0x08 | |||
| fast_idle_mode = 0x08, | |||
| enable_elasticity = 0x10 | |||
There was a problem hiding this comment.
It'd be nice to see a few lines of comment added here to let the next person know what each of these flags/options is for.
|
@biddisco your comments have been addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_used_processing_units()fornon-elastic pools
This specifically leaves open the issue of
get_used_processing_units()returning an unprotected reference to the mask. This has to be resolved separately.