Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDL2: disable parallel make #31892

Merged
merged 1 commit into from Nov 21, 2017
Merged

SDL2: disable parallel make #31892

merged 1 commit into from Nov 21, 2017

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Nov 21, 2017 •
edited

Example failure: https://hydra.nixos.org/build/64494600
It could be fixed more properly, but for me it builds under 80 secs anyway.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@vcunat
SDL2: disable parallel make
3772338 
Example failure: https://hydra.nixos.org/build/64494600
It could be fixed more properly, but for me it builds under 80 secs anyway.
@vcunat vcunat merged commit 3772338 into NixOS:master Nov 21, 2017
@vcunat vcunat deleted the p/SDL2-parallel branch November 21, 2017 12:24
@orivej
Copy link
Contributor

orivej commented Nov 21, 2017

You have committed this already to staging in 020a666.

@orivej
Copy link
Contributor

orivej commented Nov 21, 2017

Ah, you've committed this to gcc-7 in 80e8e55 and I picked it to staging :)

@vcunat
Copy link
Member Author

vcunat commented Nov 21, 2017

:-D I completely forgot. Whoever merges, feel free to resolve the conflict in any sane way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vcunat @orivej @GrahamcOfBorg