wimlib: init at 1.12.0 #31898
Merged
wimlib: init at 1.12.0 #31898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Nov 21, 2017
| for testfile in tests/test-*; do | ||
| substituteInPlace $testfile --replace "/usr/bin/env bash" "${bash}/bin/bash" | ||
| wrapProgram $testfile --prefix PATH : ${lib.makeBinPath prefixPackages} | ||
| done |
There was a problem hiding this comment.
Is patchShebangs . also able to fix shebangs here? Adding prefixPackages to buildInputs should also make wrapProgram superfluous.
|
|
Mic92
reviewed
Nov 21, 2017
| doCheck = true; | ||
|
|
||
| preCheck = '' | ||
| patchShebangs tests |
There was a problem hiding this comment.
Correct me if I am wrong, but the extra commands where not required to pass the test suite.
There was a problem hiding this comment.
some of the tests are supposed to execute ntfs3g. The tests are setup in a way that skips execution if the optional binaries are not available.
There was a problem hiding this comment.
the amount of skipped tests where the same in both cases, so I assume they cannot run in the build sandbox.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)