Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-zsh-completions: 0.3.3 -> 0.3.5, nix-bash-completions: 0.4 -> 0.5 #31897

Merged
merged 2 commits into from Nov 21, 2017
Merged

nix-zsh-completions: 0.3.3 -> 0.3.5, nix-bash-completions: 0.4 -> 0.5 #31897

merged 2 commits into from Nov 21, 2017

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Nov 21, 2017 •
edited

These have no dependencies and should be safe to backport to 17.09.

Motivation for this change

New version of nix-zsh-completions (changelog) and nix-bash-completions (changelog).

Some highlights:

  • Attribute completion for cached repos specified with an url, eg. nix-build channel:nixos-17.09 -A .... This is somewhat untested on 1.12 as nix on my machine refuses to download any repos due to lack of signatures.
  • --include|-I completion for all compatible commands. (only nix takes the includes into account when completing attribute paths though)
  • All file like completion now should work sanely in bash, ie. just like ls and similar commands
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@hedning
nix-zsh-completions: 0.3.3 -> 0.3.5
d1635a5 
Various improvements including attribute completion when supplying a cached
url as a repo.
@hedning
nix-bash-completions: 0.4 -> 0.5
9a27fee 
Various improvements and bugfixes.
@Mic92 Mic92 merged commit e5cc4bd into NixOS:master Nov 21, 2017
@Mic92 Mic92 added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 21, 2017
@orivej orivej added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Dec 23, 2017
@hedning hedning deleted the nix-zsh/bash-completions_bump branch March 1, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hedning @bjornfor @globin @Mic92 @orivej @GrahamcOfBorg