Refactor one_size_heap code to simplify code #2984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hkaiser
commented
Nov 3, 2017
hkaiser
commented
- all components can now use the same implementation of the one_size_list_heap, this should reduce compile time and code size
sithhell
reviewed
Nov 3, 2017
What I meant is that all components use the same pool implementation, not the same instance (i.e. the pools are type-erased/non-templatized). |
hkaiser
force-pushed
the
one_size_heap
branch
from
99b90c5
to
c916a7f
Compare
|
FWIW, I'm seeing ~5% reduction in binary size for the core HPX library from this. |
- all components can now use the same implementation of the one_size_list_heap, this should reduce compile time and code size
hkaiser
force-pushed
the
one_size_heap
branch
from
c916a7f
to
fb75156
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.