qt5: fix cmake cleanup on darwin #31213
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the case where the `find` command does not return any files.
orivej
approved these changes
Nov 3, 2017
GrahamcOfBorg
added
10.rebuild-darwin: 101-500
10.rebuild-linux: 0
|
@GrahamcOfBorg pcl |
GrahamcOfBorg
approved these changes
Nov 4, 2017
There was a problem hiding this comment.
For system: x86_64-linux
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
23 16.0M 23 3784k 0 0 3784k 0 0:00:04 --:--:-- 0:00:04 5026k
62 16.0M 62 10.0M 0 0 10.0M 0 0:00:01 0:00:01 --:--:-- 5728k
100 16.0M 100 16.0M 0 0 8206k 0 0:00:02 0:00:02 --:--:-- 6056k
fetching path ‘/nix/store/cfywmws250ydn7p01ljvgblcvzv0sdba-pcl-1.8.1’...
*** Downloading ‘https://cache.nixos.org/nar/07dn5sn8p9p40n7hj5ff2wvqmmwjdfx1zyygmajlm5yknqgvl81z.nar.xz’ (signed by ‘cache.nixos.org-1’) to ‘/nix/store/cfywmws250ydn7p01ljvgblcvzv0sdba-pcl-1.8.1’...
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
18 13.8M 18 2657k 0 0 2657k 0 0:00:05 --:--:-- 0:00:05 3942k
64 13.8M 64 9121k 0 0 9121k 0 0:00:01 0:00:01 --:--:-- 4960k
100 13.8M 100 13.8M 0 0 7108k 0 0:00:02 0:00:02 --:--:-- 4925k
100 13.8M 100 13.8M 0 0 7108k 0 0:00:02 0:00:02 --:--:-- 4925k
/nix/store/cfywmws250ydn7p01ljvgblcvzv0sdba-pcl-1.8.1
GrahamcOfBorg
approved these changes
Nov 4, 2017
There was a problem hiding this comment.
Success for system: x86_64-darwin
/nix/store/sdkp97xid0ca22np8lqcsrf86fvm3350-pcl-1.8.1/lib/libpcl_segmentation.1.8.1.dylib: fixing dylib
/nix/store/sdkp97xid0ca22np8lqcsrf86fvm3350-pcl-1.8.1/lib/libpcl_stereo.1.8.1.dylib: fixing dylib
/nix/store/sdkp97xid0ca22np8lqcsrf86fvm3350-pcl-1.8.1/lib/libpcl_surface.1.8.1.dylib: fixing dylib
/nix/store/sdkp97xid0ca22np8lqcsrf86fvm3350-pcl-1.8.1/lib/libpcl_tracking.1.8.1.dylib: fixing dylib
/nix/store/sdkp97xid0ca22np8lqcsrf86fvm3350-pcl-1.8.1/lib/libpcl_visualization.1.8.1.dylib: fixing dylib
stripping (with flags -S) in /nix/store/sdkp97xid0ca22np8lqcsrf86fvm3350-pcl-1.8.1/lib /nix/store/sdkp97xid0ca22np8lqcsrf86fvm3350-pcl-1.8.1/bin
patching script interpreter paths in /nix/store/sdkp97xid0ca22np8lqcsrf86fvm3350-pcl-1.8.1
copying 1 paths...
copying path '/nix/store/sdkp97xid0ca22np8lqcsrf86fvm3350-pcl-1.8.1'...
/nix/store/sdkp97xid0ca22np8lqcsrf86fvm3350-pcl-1.8.1
LnL7
approved these changes
Nov 4, 2017
|
@acowley any idea if this is also a problem on 17.09? |
|
With respect to If you are asking about qt5 in 17.09, I’d not seen this particular issue before. The change in this PR seems like an absolute improvement. I feel like backporting the change would be good, but maybe that’s naïve on my part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the case where the
findcommand does not return anyfiles.
Motivation for this change
This was breaking the end of the
installPhaseof thepclpackage ondarwin.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)