Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode-extension-ms-python-python: Init at 0.8.0 #31221

Merged
merged 1 commit into from Dec 12, 2017
Merged

vscode-extension-ms-python-python: Init at 0.8.0 #31221

merged 1 commit into from Dec 12, 2017

Conversation

jraygauthier
Copy link
Member

Motivation for this change

Missing vscode extension.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Nov 25, 2017

Could you rebase this and ping me? I'll merge it then.

@Mic92
Copy link
Member

Mic92 commented Nov 25, 2017

url returns 404:

trying https://donjayamanne.gallery.vsassets.io/_apis/public/gallery/publisher/donjayamanne/extension/python/0.7.0/assetbyname/Microsoft.VisualStudio.Services.VSIXPackage
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:--  0:00:06 --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found
error: cannot download donjayamanne-python.zip from any mirror
builder for '/nix/store/ji9mhba1i28545kj3gk0d2fl132havr9-donjayamanne-python.zip.drv' failed with exit code 1
cannot build derivation '/nix/store/f7ijlwhl8p7i48wr4fjm942yzf4g6qm9-vscode-extension-donjayamanne-python-0.7.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/f7ijlwhl8p7i48wr4fjm942yzf4g6qm9-vscode-extension-donjayamanne-python-0.7.0.drv' failed

@jraygauthier
Copy link
Member Author

@Mic92 you're right. It seems microsoft just forked the publisher's repository and changed the publisher to ms-python. On they original repository, there is a mention of the transfer of maintainer.

it gives us the following:

https://ms-python.gallery.vsassets.io/_apis/public/gallery/publisher/ms-python/extension/python/0.7.0/assetbyname/Microsoft.VisualStudio.Services.VSIXPackage

but it seems there is a new version which I should upgrade us to

https://ms-python.gallery.vsassets.io/_apis/public/gallery/publisher/ms-python/extension/python/0.8.0/assetbyname/Microsoft.VisualStudio.Services.VSIXPackage

will ping you when done.

@jraygauthier jraygauthier force-pushed the jrg/vscode-ext-python branch 2 times, most recently from 4ba7c75 to d68f8e3 Compare November 27, 2017 03:00
@jraygauthier jraygauthier changed the title vscode-extension-donjayamanne-python: Init at 0.7.0 vscode-extension-ms-python-python: Init at 0.8.0 Nov 27, 2017
@jraygauthier
Copy link
Member Author

@FRidh & @Mic92 rebased, fixed url and moved to lastest 0.8.0 version,

@FRidh FRidh merged commit 1817ec7 into NixOS:master Dec 12, 2017
@jraygauthier
Copy link
Member Author

Thank you for the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jraygauthier @FRidh @Mic92 @GrahamcOfBorg