Mtail #31215
Merged
Mtail #31215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orivej
suggested changes
Nov 4, 2017
| @@ -2,16 +2,16 @@ | |||
|
|
|||
| buildGoPackage rec { | |||
| name = "gotools-${version}"; | |||
| version = "20160519-${stdenv.lib.strings.substring 0 7 rev}"; | |||
| rev = "9ae4729fba20b3533d829a9c6ba8195b068f2abc"; | |||
| version = "20170807-${stdenv.lib.strings.substring 0 7 rev}"; | |||
There was a problem hiding this comment.
Use commit message `gotools: 20160519 -> 20170807"
|
|
||
| buildGoPackage rec { | ||
| name = "mtail-${version}"; | ||
| version = "v3.0.0-rc4"; |
There was a problem hiding this comment.
v should not be a part of the version, it is only a part of rev.
Use commit message mtail: init at 3.0.0-rc4 (see https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).
|
@orivej master done, "20170807" done, "intit at" done. Is it possible to get this into 17.09, or new packages are only accepted into master? |
orivej
approved these changes
Nov 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add new package - mtail.
mtail is a tool for extracting metrics from application logs to be exported into a timeseries database or timeseries calculator for alerting and dashboarding.
https://github.com/google/mtail
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)