Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: fix compilation when ldap header exists on host system #31216

Merged
merged 1 commit into from Nov 4, 2017
Merged

php: fix compilation when ldap header exists on host system #31216

merged 1 commit into from Nov 4, 2017

Conversation

jbboehr
Copy link
Contributor

@jbboehr jbboehr commented Nov 4, 2017 •
edited

Motivation for this change

Fixes #20491 - compilation fails when ldap.h exists on the host system and sandboxing is disabled. This fix works by tricking the configure script into not checking /usr and /usr/local which then falls back on the environment variables:
https://github.com/php/php-src/blob/d3fa900780994ae812b5314900556a7f1bfb916e/ext/ldap/config.m4#L97

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jbboehr
Copy link
Contributor Author

jbboehr commented Nov 4, 2017

Now it looks like the build is timing out...

The log length has exceeded the limit of 4 MB (this usually means that the test suite is raising the same exception over and over). The job has been terminated

@orivej orivej merged commit 75a7763 into NixOS:master Nov 4, 2017
@orivej
Copy link
Contributor

orivej commented Nov 4, 2017

Thank you!

Now it looks like the build is timing out...

No, it just generates a lot of output, so Travis terminates it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP fails to build on Debian
3 participants
@jbboehr @orivej @GrahamcOfBorg