Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calibre: Fix error when sending E-Mails #31936

Merged
merged 1 commit into from Nov 22, 2017
Merged

calibre: Fix error when sending E-Mails #31936

merged 1 commit into from Nov 22, 2017

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Nov 22, 2017 •
edited

Motivation for this change

When sending E-Mails an error was thrown due to the missing 'dns'
python package. See issue #31935

I've tested the package on 17.09, it cherry-picks cleanly and works there as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Moredread
calibre: Fix error when sending E-Mails
04bdff3 
When sending E-Mails an error was thrown due to the missing 'dns'
python package.
@FRidh FRidh merged commit fe84985 into NixOS:master Nov 22, 2017
@FRidh
Copy link
Member

FRidh commented Nov 22, 2017

Thanks!

@FRidh FRidh mentioned this pull request Nov 22, 2017
Closed
@Moredread Moredread deleted the calibre branch November 22, 2017 19:06
@Moredread
Copy link
Contributor Author

Would you consider cherry-picking the commit on the release-17.09 branch, please? I've tested it there, and it works fine.

Because the patch only adds a dependency and fixes a serious issue, disabling a rather large feature, I think it well suitated for a backport

@FRidh
Copy link
Member

FRidh commented Nov 22, 2017

Pushed 5db4e63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Moredread @FRidh @GrahamcOfBorg