Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crystal: fix CRYSTAL_PATH #31927

Merged
merged 1 commit into from Nov 22, 2017
Merged

crystal: fix CRYSTAL_PATH #31927

merged 1 commit into from Nov 22, 2017

Conversation

sifmelcara
Copy link
Member

@sifmelcara sifmelcara commented Nov 22, 2017 •
edited

Fixes #31844

The crystal compiler tries to search crystal dependencies by looking at CRYSTAL_PATH,
this commit adds lib to CRYSTAL_PATH, so that crystal can find dependencies installed locally by shards.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@sifmelcara
crystal: fix CRYSTAL_PATH
817d0a8 
CRYSTAL_PATH should contain `lib` to make crystal able to find required
libraries installed in current directory.
@orivej orivej merged commit 4fe5e59 into NixOS:master Nov 22, 2017
@orivej
Copy link
Contributor

orivej commented Nov 22, 2017

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sifmelcara @orivej