Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-secret: init at 0.2.2 #31486

Merged
merged 3 commits into from Nov 10, 2017
Merged

git-secret: init at 0.2.2 #31486

merged 3 commits into from Nov 10, 2017

Conversation

lo1tuma
Copy link
Member

@lo1tuma lo1tuma commented Nov 10, 2017

Motivation for this change

git-secret is a bash tool to store your private data inside a git repo.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Copy link
Member

@lukateras lukateras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and works!

meta = {
description = "A bash-tool to store your private data inside a git repository.";
homepage = http://git-secret.io;
license = lib.licenses.mit;
Copy link
Member

@lukateras lukateras Nov 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically stdenv.lib is used instead of lib.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@@ -0,0 +1,36 @@
{ pkgs, stdenv, lib, fetchFromGitHub, makeWrapper, git, gnupg }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkgs is not used in this derivation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, removed.

@Mic92 Mic92 merged commit b627615 into NixOS:master Nov 10, 2017
@lo1tuma lo1tuma deleted the git-secret branch November 11, 2017 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants