Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.nbconvert: fix failing tests on darwin #31487

Merged
merged 1 commit into from Nov 10, 2017

Conversation

jbaum98
Copy link
Contributor

@jbaum98 jbaum98 commented Nov 10, 2017

Motivation for this change

nbconvert is failing to install on my darwin machine because of failing tests caused by LC_ALL being set to en_US.utf8 instead of en_US.UTF-8.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7
Copy link
Member

LnL7 commented Nov 10, 2017

@GrahamcOfBorg pythonPackages.nbconvert

@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Nov 10, 2017
Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

  /tmp/nix-build-python2.7-nbconvert-5.3.1.drv-0/nbconvert-5.3.1/nbconvert/filters/datatypefilter.py:41: UserWarning: Your element with mimetype(s) ['hair', 'water', 'rock'] is not able to be represented.
    mimetypes=output.keys())

nbconvert/filters/tests/test_datatypefilter.py::TestDataTypeFilter::test_null
  /tmp/nix-build-python2.7-nbconvert-5.3.1.drv-0/nbconvert-5.3.1/nbconvert/filters/datatypefilter.py:41: UserWarning: Your element with mimetype(s) [] is not able to be represented.
    mimetypes=output.keys())

-- Docs: http://doc.pytest.org/en/latest/warnings.html
============= 206 passed, 29 skipped, 3 warnings in 248.08 seconds =============
/nix/store/gnmfa5y8pjjc0hw0a4if0hb67zy0rnx8-python2.7-nbconvert-5.3.1

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin


nbconvert/filters/tests/test_datatypefilter.py::TestDataTypeFilter::test_null
  /private/tmp/nix-build-python2.7-nbconvert-5.3.1.drv-0/nbconvert-5.3.1/nbconvert/filters/datatypefilter.py:41: UserWarning: Your element with mimetype(s) [] is not able to be represented.
    mimetypes=output.keys())

-- Docs: http://doc.pytest.org/en/latest/warnings.html
============= 206 passed, 29 skipped, 3 warnings in 112.50 seconds =============
copying 1 paths...
copying path '/nix/store/x9rsqs9xc9p8j12d6bfca8z0wls63yij-python2.7-nbconvert-5.3.1'...
/nix/store/x9rsqs9xc9p8j12d6bfca8z0wls63yij-python2.7-nbconvert-5.3.1

@LnL7 LnL7 merged commit 0e92951 into NixOS:master Nov 10, 2017
@jbaum98 jbaum98 deleted the nbconvert branch November 10, 2017 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants