Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: language-c: add hack to deal with _Float128 in glibc #31498

Closed
wants to merge 1 commit into from
Closed

WIP: language-c: add hack to deal with _Float128 in glibc #31498

wants to merge 1 commit into from

Conversation

corngood
Copy link
Contributor

@corngood corngood commented Nov 10, 2017 •
edited

Fixes #31411

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@corngood corngood requested a review from peti as a code owner November 10, 2017 19:36
@corngood corngood mentioned this pull request Nov 10, 2017
Closed
peti
peti requested changes Nov 11, 2017
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have to replace the release version of language-c for the entire package set? Wouldn't it suffice to build c2hs with the latest git version?

@peti peti closed this in c6d9b5d Nov 11, 2017
@corngood
Copy link
Contributor Author

@peti that should fix the broken packages, but the incompatibility is between the current versions of language-c and glibc in nixpkgs. That was my reasoning for making it global, but your fix looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti requested changes

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@corngood @peti @vcunat @GrahamcOfBorg