awscli: 1.11.162 -> 1.11.185 #31488
Merged
awscli: 1.11.162 -> 1.11.185 #31488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orivej
suggested changes
Nov 10, 2017
pkgs/top-level/all-packages.nix
Outdated
|
|
||
| awsebcli = callPackage ../tools/virtualization/awsebcli {}; | ||
|
|
||
| awslogs = callPackage ../tools/admin/awslogs { }; | ||
|
|
||
| aws_shell = python2Packages.aws_shell; # Should be moved out of python-packages.nix | ||
| aws_shell = callPackage ../tools/admin/aws_shell { }; |
There was a problem hiding this comment.
It is better to use pythonPackages.callPackage, and list python dependencies in the arguments of the function that returns the derivation.
There was a problem hiding this comment.
I agree. This is now changed.
pkgs/top-level/python-packages.nix
Outdated
| feedgen = callPackage ../development/python-modules/feedgen { }; | ||
|
|
||
| feedgenerator = callPackage ../development/python-modules/feedgenerator { | ||
| inherit (pkgs) glibcLocales; | ||
| }; | ||
|
|
||
| s3transfer = callPackage ../development/python-modules/s3transfer { }; |
There was a problem hiding this comment.
Maybe you didn't mean to move s3transfer here from its old place far below?
There was a problem hiding this comment.
Not intentional. Fixed!
orivej
approved these changes
Nov 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Upstream API updates.
Had to update
botocoreands3transferfor this.awscliandaws_shellno longer lives inpythonPackages.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)