Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webkitgtk: 2.18.2 -> 2.18.3 (fixes multiple CVE's) #31502

Merged
merged 1 commit into from Nov 13, 2017
Merged

webkitgtk: 2.18.2 -> 2.18.3 (fixes multiple CVE's) #31502

merged 1 commit into from Nov 13, 2017

Conversation

disassembler
Copy link
Member

@disassembler disassembler commented Nov 10, 2017 •
edited

Motivation for this change

https://webkitgtk.org/security/WSA-2017-0009.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@disassembler
Copy link
Member Author

This is compiling currently, but updating version/sha patches still applied so I'm hopeful we won't have any problems here.

@disassembler
Copy link
Member Author

Set rebuild to 501+ based on the recently closed webkitgtk issue. Assume this will touch the same stuff.

@orivej orivej changed the base branch from master to staging November 10, 2017 22:01
@orivej orivej changed the base branch from staging to master November 10, 2017 22:01
orivej
orivej reviewed Nov 10, 2017
View reviewed changes
pkgs/development/libraries/webkitgtk/2.18.nix Outdated
@@ -12,7 +12,7 @@ assert enableGeoLocation -> geoclue2 != null;
with stdenv.lib;
stdenv.mkDerivation rec {
name = "webkitgtk-${version}";
version = "2.18.1";
version = "2.18.3";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please submit this against staging where version is 2.18.2 already.

@disassembler disassembler changed the base branch from master to staging November 10, 2017 22:31
@grahamc
Copy link
Member

grahamc commented Nov 11, 2017

Please ensure that when you merge this, it is backported to 17.09 (with the other webkitgtk bumps too. Backport with git cherry-pick -x)

@vcunat vcunat added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 11, 2017
@globin
Copy link
Member

globin commented Nov 11, 2017

@nixborg build

@nixborg
Copy link

nixborg commented Nov 11, 2017

Jobset created at https://hydra.mayflower.de/jobset/nixos/pr-31502

@globin globin merged commit 6e686ff into NixOS:staging Nov 13, 2017
@pbogdan pbogdan mentioned this pull request Nov 21, 2017
Merged
8 tasks
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc approved these changes

@orivej orivej orivej approved these changes

@fpletz fpletz Awaiting requested review from fpletz

@vcunat vcunat Awaiting requested review from vcunat

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@disassembler @grahamc @globin @nixborg @orivej @samueldr @vcunat @GrahamcOfBorg