llvm: glibc 2.26 fixes #31501
Merged
llvm: glibc 2.26 fixes #31501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcunat
approved these changes
Nov 10, 2017
|
I thought llvm-3.4 could be dropped, but as you've fixed it, I won't do that (yet). |
vcunat
added a commit
that referenced
this pull request
Nov 10, 2017
|
Heh, GitHub mixing up users again. |
|
Interesting, haven't seen that before on github. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Packages won't build with glibc 2.26.
Note that I don't really know what I'm doing here beyond adding a patch @vcunat already applied to newer llvm versions, and adding a hack to inject
#include <signal.h>. I'm submitting this in hopes that at very least it might help avoid some duplicate work.Out of dependent packages
purePackages.genfails to build however it's been broken for quite some time already.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)