Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postage: replaced by pgmanage-10.0.2 #31149

Merged
merged 1 commit into from Nov 3, 2017
Merged

Conversation

basvandijk
Copy link
Member

postage is no longer maintained and has been replaced by the identical pgmanage.

I replaced pkgs.postage with pkgs.pgmanage and renamed the corrersponding NixOS module.

When a user enables the deprecated services.postage.enable option the following error will be raised:

Failed assertions:
- services.postage is deprecated in favor of pgmanage. They have the same options so just substitute postage for pgmanage.

A new test tests.pgmanage has been added which builds successfully.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7
Copy link
Member

LnL7 commented Nov 2, 2017

Could you add an entry to the 18.03 release-notes for this.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 2, 2017

It may also be worthy of an entry in aliases.nix for retro-compatibility.

postage is no longer maintained and has been replaced by the identical pgmanage. See:

https://github.com/workflowproducts/postage#postage-has-been-replaced-with-pgmanage

The following error is raised when a user enables the deprecated `services.postage.enable` option:

Failed assertions:
- services.postage is deprecated in favor of pgmanage. They have the same options so just substitute postage for pgmanage.
@basvandijk
Copy link
Member Author

Done.

@LnL7 LnL7 merged commit 9a15344 into NixOS:master Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants