Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libdwarf: 20161124 -> 20170709 #31143

Merged
merged 1 commit into from Nov 2, 2017
Merged

libdwarf: 20161124 -> 20170709 #31143

merged 1 commit into from Nov 2, 2017

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Nov 2, 2017

Motivation for this change

Fixes a few vulnerabilities and some dwarf5 support maybe.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Nov 2, 2017

Any known incompatibilities?

@dtzWill
Copy link
Member Author

dtzWill commented Nov 2, 2017

I'm not sure, sorry. Was just using the tool and saw there was a new version with various "vulnerabilities" fixed among other things so thought I'd wrap it up.

@grahamc does the label mean "1-10", aka "not-zero"? If so great, if not (maybe means "10" if I'm parsing wrong) then I think it's mistaken, not much depends on it. (I'm expecting/hoping travis will complete, for example).

Running nox-review locally.

@dtzWill
Copy link
Member Author

dtzWill commented Nov 2, 2017

(nevermind re:being quick to check, hhvm is taking forever to build and apparently serially builds all its vendored libraries 😭)

@dtzWill
Copy link
Member Author

dtzWill commented Nov 2, 2017

Previously API/ABI compat was checked with this: https://abi-laboratory.pro/tracker/timeline/libdwarf/

Which seems good to me.

@orivej
Copy link
Contributor

orivej commented Nov 2, 2017

I can not check this because php does not build, unrelated to this PR.

@grahamc
Copy link
Member

grahamc commented Nov 2, 2017 via email

@Mic92 Mic92 merged commit eb4c905 into NixOS:master Nov 2, 2017
@Mic92
Copy link
Member

Mic92 commented Nov 2, 2017

Everything still compiles on my machine.

@Mic92
Copy link
Member

Mic92 commented Nov 2, 2017

Everything still compiled on my system.

vcunat pushed a commit that referenced this pull request Nov 3, 2017
@Mic92 @vcunat
Merge #31143: libdwarf: 20161124 -> 20170709
1d3ba19 
(cherry picked from commit eb4c905)
According to upstream announcements it fixes vulnerabilities.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @Mic92 @orivej @grahamc @GrahamcOfBorg