phpPackages.redis: rev 4a37e4 -> 3.1.4 #31158
Merged
+4
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamcOfBorg
added
10.rebuild-linux: 1-10
10.rebuild-darwin: 0
|
Thanks! |
|
Does this need a backport? |
|
@Mic92 Assuming you are asking me, I'm not sure, although it seems wise to use a tagged release when possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The redis extension for PHP7 has been officially released for a while now.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)Since the tests require a live redis server, I tested the extension using
nix-shell default.nix -A php70Packages.redisandnix-shell default.nix -A php71Packages.redisand running the test manually in a checkout of the source repository instead of enablingdoCheck.Like #31153, I'm testing on a multi-user setup on Ubuntu Xenial. nox-review and sandboxing do not appear to be working on my setup currently.