Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpPackages.apcu: 5.1.2 -> 5.1.8 and enable tests #31153

Merged
merged 1 commit into from Nov 3, 2017
Merged

phpPackages.apcu: 5.1.2 -> 5.1.8 and enable tests #31153

merged 1 commit into from Nov 3, 2017

Conversation

jbboehr
Copy link
Contributor

@jbboehr jbboehr commented Nov 2, 2017

Motivation for this change

Fixes #30734 - 5.1.2 segfaults

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I'm using a multi-user setup on Ubuntu Xenial at the moment, and getting this when I enable sandboxing (considering I just changed the version, I wouldn't expect this to be a result of my change):

/nix/store/dkrn0k8hxqcdk0bmap3dx41ln0y5cvrf-php-7.0.24-dev/bin/phpize: /nix/store/463g7ww3vdy5bkrl5ycvlqfnxfsz4q76-autoconf-2.69/bin/autoconf: /bin/sh: bad interpreter: No such file or directory

I'm also not sure how to get the alternate, shorter sha256 - I tried using the one from the source folder in /nix/store but it was much shorter.

@jbboehr jbboehr mentioned this pull request Nov 2, 2017
Merged
8 tasks
@Mic92
Copy link
Member

Mic92 commented Nov 3, 2017 •
edited

The error you are experience, is probably due being /bin/sh not available in sandbox.
Your build-sandbox-paths in /etc/nix/nix.conf should normally contain something like /bin/sh=/nix/store/h404wfcz8rzzlq8vr4z7plcijwzfci72-bash-4.4-p12/bin/bash.

@Mic92 Mic92 merged commit 60c4104 into NixOS:master Nov 3, 2017
@Mic92
Copy link
Member

Mic92 commented Nov 3, 2017

Does this also needs to be fixed on 17.09?

@jbboehr
Copy link
Contributor Author

jbboehr commented Nov 3, 2017

@Mic92 As far as I know, this affects all the way back to 16.03 when apcu was introduced. I've been testing my development setup by deploying from Ubuntu using nixops to virtualbox, so I'm not actually sure which version is being used, although nixos-version in the VM is reporting 18.03pre117581.9b177399c4 and nix-channel --list inside the VM is reporting 16.09 and nix-channel --list outside the VM is using nixpkgs-unstable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

php-apcu 5.1.2 segfault
4 participants
@jbboehr @Mic92 @GrahamcOfBorg @Janik-Haag