New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mkPythonDerivation: let name default to ${pname}-${version} #31173
Conversation
Some more clarification. I very much like this change and want this to happen as well, but I think we need to be sure whether this is the right direction. That is, perhaps we should fill in |
Specifying neither |
By the way, do you want to replace the usage of |
To easily fetch another version. See e.g. a3e5240#diff-9a467ecbd5ed7def480033cf9289509aR9 |
Tested it. Great! |
Unfortunately it doesn't work as I hoped it would. Building
will give a version of |
@FRidh You have to use |
Ohh doh, how did I miss that. Thanks! |
The `name` attribute is filled in when `pname` and `version` are specified. See #31173
Motivation for this change
Python packages that use
fetchPypi
typically refer only to theirpname
andversion
instead ofname
, but have to definename = "${pname}-${version}";
to conform to the interface ofmkDerivation
. @FRidh has proposed to get rid of this.This commit rebuilds nothing. I've tested it by deleting the name from a python derivation. If we migrate
python-packages.nix
intopython-modules/
automatically, we could delete unneeded names in the process.Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)