Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bundlerEnv: support unicode executables #31145

Merged
merged 1 commit into from Nov 3, 2017
Merged

bundlerEnv: support unicode executables #31145

merged 1 commit into from Nov 3, 2017

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Nov 2, 2017 •
edited

Motivation for this change

This fixes nix-community/bundix#19

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@manveru manveru requested a review from zimbatm as a code owner November 2, 2017 19:01
zimbatm
zimbatm approved these changes Nov 2, 2017
View reviewed changes
Copy link
Member

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. running nox-review just for sanity checking.

@zimbatm
Copy link
Member

zimbatm commented Nov 3, 2017

nox-review is passing

@zimbatm zimbatm merged commit d36a83a into NixOS:master Nov 3, 2017
@cstrahan
Copy link
Contributor

cstrahan commented Nov 5, 2017

Thanks, @manveru!

@manveru manveru deleted the support-bundler-unicode-executables branch November 30, 2017 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm zimbatm approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bundix fails to install gem if binary has unicode character in its name (e.g. emoji)
4 participants
@manveru @zimbatm @cstrahan @GrahamcOfBorg