Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvidia-x11-stable: 384.90 -> 387.22 #31148

Closed
wants to merge 1 commit into from
Closed

nvidia-x11-stable: 384.90 -> 387.22 #31148

wants to merge 1 commit into from

Conversation

MP2E
Copy link

@MP2E MP2E commented Nov 2, 2017 •
edited

Motivation for this change

Updates the nvidia-x11 driver to the newest stable to support the 1070 Ti, and give us the latest fixes for other cards.

In addition to being a version bump, it required me to comment out NIX_LDFLAGS in settings.nix, and I want to be sure that didn't break anything because I don't know the intention of why it was added. nvidia-settings is working on my setup with no noticeable changes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Nov 3, 2017

cc @vcunat

@vcunat
Copy link
Member

vcunat commented Nov 3, 2017

NIX_LDFLAGS is due to 362ef37. IIRC we had problems with finding some libraries during runtime; @abbradar might remember more details.

@MP2E MP2E mentioned this pull request Nov 14, 2017
Closed
13 tasks
@NeQuissimus
Copy link
Member

Could somebody with an nvidia card give this a try?

@FRidh FRidh self-assigned this Nov 16, 2017
@adisbladis
Copy link
Member

I can confirm this is working on kernel 4.14.0.

@NeQuissimus
Copy link
Member

@abbradar @vcunat Are we worried about the NIX_LDFLAGS if people report this is working?!

@adisbladis
Copy link
Member

Tried nvidia-settings now and that is not working properly. optirun nvidia-settings results in https://gist.github.com/adisbladis/a2d800d8a103232fd5de1a0e40643dad

@adisbladis
Copy link
Member

Followed the instructions on the bumblebee wiki (optirun -b none nvidia-settings -c :8) and nvidia-settings starts up just fine so it seems like my issue was specific to using bumblebee.

@MP2E
Copy link
Author

MP2E commented Nov 22, 2017 •
edited

Since it seems there are no issues in changing the LDFLAGS, I'll go ahead and push to master.

If this causes issues, feel free to revert and I will investigate, but I am confident at this point that it will not.

@MP2E MP2E closed this Nov 22, 2017
@MP2E MP2E deleted the nvidia_update branch November 22, 2017 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@FRidh FRidh

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@MP2E @FRidh @vcunat @NeQuissimus @adisbladis @GrahamcOfBorg