Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] lxcfs,pam: disable cgmanager, enable pam_cgfs, lxcfs 2.0.7 -> 2.0.8 #31157

Merged
merged 5 commits into from Jan 1, 2018
Merged

[wip] lxcfs,pam: disable cgmanager, enable pam_cgfs, lxcfs 2.0.7 -> 2.0.8 #31157

merged 5 commits into from Jan 1, 2018

Conversation

sorki
Copy link
Member

@sorki sorki commented Nov 2, 2017

Motivation for this change

Deprecation of cgmanager, switch to pam_cgfs, see #30023

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@sorki
Copy link
Member Author

sorki commented Nov 2, 2017

Marked as work in progress, needs testing on stock NixOS, especially parameters passed to pam_cgfs needs verifying.

@Mic92
Copy link
Member

Mic92 commented Nov 7, 2017

I tested this with cgroupv1. I also want to test cgroupv2, when I reboot later.

@Mic92 Mic92 merged commit 0bbf671 into NixOS:master Jan 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sorki @Mic92 @GrahamcOfBorg