Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ngspice: Build shared library #31166

Merged
merged 1 commit into from Nov 3, 2017
Merged

ngspice: Build shared library #31166

merged 1 commit into from Nov 3, 2017

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Nov 3, 2017

This builds the libngspice shared library which is used by development
versions of kicad.

Motivation for this change

Enable linkage against libngspice shared library

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bgamari
ngspice: Build shared library
7eecac6 
This builds the libngspice shared library which is used by development
versions of kicad.
@Mic92 Mic92 merged commit 7e36df2 into NixOS:master Nov 3, 2017
@Mic92
Copy link
Member

Mic92 commented Nov 3, 2017

Thanks!

@bgamari bgamari mentioned this pull request Mar 22, 2018
Merged
8 tasks
bgamari added a commit to bgamari/nixpkgs that referenced this pull request Mar 25, 2018
@bgamari
ngspice: Move shared library to a new derivation
a62fffd 
It turns out that the build system does not support building both the
command-line tool and the shared library at the same time. Consequently
the ngspice derivation has not provided the command-line tools since the
shared library was enabled in NixOS#31166.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bgamari @Mic92 @GrahamcOfBorg