Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipmicfg: init at 1.27.0 #31159

Merged
merged 3 commits into from
Nov 2, 2017
Merged

ipmicfg: init at 1.27.0 #31159

merged 3 commits into from
Nov 2, 2017
+36 −0

Conversation

sorki
Copy link
Member

@sorki sorki commented Nov 2, 2017

Motivation for this change

New package. Also contains commit adding me to maintainers.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

sorki added 2 commits November 2, 2017 22:19
@sorki
add sorki to maintainers

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
d1491f4
@sorki
ipmicfg: init at 1.27.0
2b37262
@sorki sorki requested review from edolstra and nbp as code owners November 2, 2017 21:21
@orivej
Copy link
Contributor

orivej commented Nov 2, 2017

Please review my changes.

@sorki
Copy link
Member Author

sorki commented Nov 2, 2017

Cool, I didn't know about fetchzip or dontPatchShebangs - looks good to me now, thank you!

@orivej orivej merged commit 9033675 into NixOS:master Nov 2, 2017
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra

@nbp nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sorki @orivej @GrahamcOfBorg