Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freetds: add openssl support #31171

Closed
wants to merge 1 commit into from

Conversation

ryantrinkle
Copy link
Contributor

Motivation for this change

This is necessary for freetds to be able to use encrypted database connections

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ryantrinkle
Copy link
Contributor Author

Note: I turned openssl support on by default, which seems sensible to me, but if there's a reason this shouldn't be done, I'm happy to change it.

@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 3, 2017

Enabling SSL support in this library is legit, but the version we're building here is rather old...

@peterhoeg previously tried an upgrade to 1.00.62 but then reverted it : what was broken?

@peterhoeg
Copy link
Member

The commit that was reverted was pushed in error - it's not ready yet.

I have a local branch here with the latest version which is needed for a project. That is working fine for my purposes, but nox-review wip didn't like it (I off-hand don't remember what broke) but I'll try to fix that.

@peterhoeg peterhoeg mentioned this pull request Nov 4, 2017
8 tasks
@orivej
Copy link
Contributor

orivej commented Nov 6, 2017

Fixed in #31224

@orivej orivej closed this Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants