Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "ocamlPackages.csv: 1.5 -> 1.7" #31054

Closed
wants to merge 1 commit into from
Closed

Revert "ocamlPackages.csv: 1.5 -> 1.7" #31054

wants to merge 1 commit into from

Conversation

tokudan
Copy link
Contributor

@tokudan tokudan commented Oct 31, 2017 •
edited

This reverts commit 574f3c3.

Motivation for this change

The previous version fails to build due to unavailable source files:

building path(s) ‘/nix/store/2f7cdgac0x6sk7xbwfzayyvfvpg0h7qa-csv-1.7.tar.gz’
  2 2285k    2 51852    0     0  51852      0  0:00:45 --:--:--  0:00:45 66391
trying https://math.umons.ac.be/anum/software/csv/csv-1.7.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0remote: Counting objects: 2938, done.        
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (22) The requested URL returned error: 404 Not Found
error: cannot download csv-1.7.tar.gz from any mirror
builder for ‘/nix/store/2ap6cx8bli5r8vfp675ys109lwxczc01-csv-1.7.tar.gz.drv’ failed with exit code 1
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Oct 31, 2017

@GrahamcOfBorg ocamlPackages.csv

@vbgl
Copy link
Contributor

vbgl commented Oct 31, 2017

Related: #30476.

@disassembler
Copy link
Member

@tokudan merge conflict, can you rebase?

@Ma27
Copy link
Member

Ma27 commented Nov 1, 2017

wouldn't make it more sense to keep 1.7, but fetch the source from GitHub: https://github.com/Chris00/ocaml-csv/releases/tag/1.7 ?

@copumpkin
Copy link
Member

Yeah, I'm with @Ma27. Revert if there's no obvious fix, but here it seems like there's a pretty easy fix

@tokudan
Copy link
Contributor Author

tokudan commented Nov 1, 2017 •
edited

@Ma27 When I looked for a solution, it was far from obvious that that git repository actually had the same source code.

Since another solution has been merged, I'll close this one.

@tokudan tokudan closed this Nov 1, 2017
@tokudan tokudan deleted the ocamlcsvtools branch November 1, 2017 18:11
@copumpkin
Copy link
Member

Cool, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tokudan @grahamc @vbgl @disassembler @Ma27 @copumpkin