Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ghcjs socket.io usage #31062

Merged
merged 1 commit into from Nov 1, 2017
Merged

Fix ghcjs socket.io usage #31062

merged 1 commit into from Nov 1, 2017

Conversation

pikajude
Copy link
Contributor

  1. Old style node packages should go away
  2. Previous fix was the worst possible way to solve the issue, and only applied to interactive shell environments (like what cabal2nix would generate).

I also originally thought NODE_PATH was deprecated, but if it works in node 6 that may not be the case.

If there's a need for, and a way to, generate NODE_PATH in such a way that it doesn't conflict with an existing NODE_PATH, that would be an appreciated fix as well.

@pikajude pikajude requested a review from peti as a code owner October 31, 2017 22:14
@pikajude pikajude mentioned this pull request Oct 31, 2017
Closed
8 tasks
@domenkozar domenkozar merged commit 737b466 into NixOS:master Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pikajude @domenkozar @GrahamcOfBorg