Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure which and curl are available in the PATH for sbt-extras #31056

Merged
merged 1 commit into from Nov 6, 2017

Conversation

purefn
Copy link
Contributor

@purefn purefn commented Oct 31, 2017

sbt-extras uses which and curl to download the sbt launcher. We should make them available on the PATH to make the package easier to use.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@purefn
Copy link
Contributor Author

purefn commented Oct 31, 2017

@puffnfresh

@grahamc
Copy link
Member

grahamc commented Oct 31, 2017

@GrahamcOfBorg sbt-extras

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For system: x86_64-linux

configuring
no configure script, doing nothing
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lz9qvqj1wlpqig0pbqs5948xm3j8qahz-sbt-extras-77686b3
stripping (with flags -S) in /nix/store/lz9qvqj1wlpqig0pbqs5948xm3j8qahz-sbt-extras-77686b3/bin
patching script interpreter paths in /nix/store/lz9qvqj1wlpqig0pbqs5948xm3j8qahz-sbt-extras-77686b3
/nix/store/lz9qvqj1wlpqig0pbqs5948xm3j8qahz-sbt-extras-77686b3/bin/.sbt-wrapped: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/h404wfcz8rzzlq8vr4z7plcijwzfci72-bash-4.4-p12/bin/bash"
checking for references to /tmp/nix-build-sbt-extras-77686b3.drv-0 in /nix/store/lz9qvqj1wlpqig0pbqs5948xm3j8qahz-sbt-extras-77686b3...
/nix/store/lz9qvqj1wlpqig0pbqs5948xm3j8qahz-sbt-extras-77686b3

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For system: x86_64-darwin

configuring
no configure script, doing nothing
installing
post-installation fixup
stripping (with flags -S) in /nix/store/aa8hfn11v6zbqbxih0497abpyz9pkl7s-sbt-extras-77686b3/bin
patching script interpreter paths in /nix/store/aa8hfn11v6zbqbxih0497abpyz9pkl7s-sbt-extras-77686b3
/nix/store/aa8hfn11v6zbqbxih0497abpyz9pkl7s-sbt-extras-77686b3/bin/.sbt-wrapped: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/axikcsz4wh2qpi5zmlfsmm4jx8wm8s1g-bash-4.4-p12/bin/bash"
copying 1 paths...
copying path '/nix/store/aa8hfn11v6zbqbxih0497abpyz9pkl7s-sbt-extras-77686b3'...
/nix/store/aa8hfn11v6zbqbxih0497abpyz9pkl7s-sbt-extras-77686b3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants