patchwork: init at 3.8.0 (WIP) #31052
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
but after that: fails with And I don't know how to fix this. It looks like dependencies are not met... so how to import them? |
matthiasbeyer
force-pushed
the
add-patchwork
branch
from
4efb6a2
to
d1d8b95
Compare
|
Okay, I feel we're getting closer: Error on 8a755f7 I don't know what |
|
Bringing |
Ma27
reviewed
Nov 1, 2017
|
|
||
| xorg = pkgs.xorg; | ||
| in | ||
| nodePackages.package.override (oldAttrs: { |
There was a problem hiding this comment.
I don't think it's necessary to place all of this into its own file, for overriding purposes https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/node-packages/default-v6.nix can be used.
After that it should be enough to add an alias to all-packages.nix.
There was a problem hiding this comment.
I would love to get it to build first, then we can discuss where it should be placed. 😅
There was a problem hiding this comment.
the package itself should be also added to https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/node-packages/node-packages-v6.json eventually.
|
So... |
matthiasbeyer
force-pushed
the
add-patchwork
branch
from
8a755f7
to
c0e3b18
Compare
|
@yegortimoshenko How to? I have no experience with this electron monster thing, let alone with the nixpkgs infrastructure around it... |
|
Hey, not sure if this helps, but I think it might be worth sharing. I got patchwork compiling and running via the following shell.nix (it's rough, but it works): with import <nixpkgs> {};
with pkgs;
let pwEnv = buildEnv {
name = "pwenv";
paths = [
alsaLib
atk
binutils
bzip2
cairo
cups
dbus.lib
expat
fontconfig
freetype
fuse
gcc
gdk_pixbuf
glib
glibc
gnome2.gtk
gnome3.gconf
gnumake
libcap
libgpgerror
libnotify
libsodium
nspr
nss
pango
readline
systemd
udev
udev
xorg.kbproto
xorg.libX11
xorg.libXScrnSaver
xorg.libXcomposite
xorg.libXcursor
xorg.libXdamage
xorg.libXext
xorg.libXfixes
xorg.libXi
xorg.libXrandr
xorg.libXrender
xorg.libXtst
xorg.libxcb
xorg.libxkbfile
xorg.xproto
zlib
];
extraOutputsToInstall = [ "lib" "dev" "out" ];
}; in
(pkgs.buildFHSUserEnv {
name = "patchwork";
targetPkgs = pkgs: (with pkgs; [
nodejs-8_x
git
python
pwEnv
]);
extraOutputsToInstall = [ "lib" "dev" "out" ];
extraBuildCommands = ''
(cd usr/lib64 && ln -sv libbz2.so.1.0.* libbz2.so.1.0)
'';
profile = ''
export npm_config_cache="/tmp/pw-npm-cache/"
export npm_config_devdir="/tmp/pw-gyp/"
export ELECTRON_CACHE="/tmp/pw-electron-cache/"
export CFLAGS="$NIX_CFLAGS_COMPILE"
export CXXFLAGS="$NIX_CFLAGS_COMPILE"
export LDFLAGS="$NIX_LDFLAGS_BEFORE"
'';
}).env |
|
@baldo wow, sounds great. I will definitively use this! |
|
Ummm... what? |
|
I'm lost here. I cloned the patchwork repository and used the expression @baldo provided for building it. I don't know how to package this and would love if someone could take over. Of course I'd maintain it then and ship updates as soon as possible. |
|
@yegortimoshenko I was told (on irc) that you have experience with electron? Care to help? |
|
@yegortimoshenko I'm still interested in this... could you please help me? |
|
Any progress on this? |
|
Since I packaged a couple of electron apps already, I'll give it a try today. |
|
@matthiasbeyer can you try #35334 and see if it works for you? |
|
On it. |
8 tasks
|
Superseded by #35334. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Closes #24784
Because nobody did yet, I'm trying to get this going. Does not work, though, as
npm2nixis broken and I do not know how to fix.Of course this is WIP and not working yet.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)