Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pip-tools: update tests for 1.9.0 -> 1.10.1 #31061

Merged
merged 1 commit into from Oct 31, 2017
Merged

pip-tools: update tests for 1.9.0 -> 1.10.1 #31061

merged 1 commit into from Oct 31, 2017

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Oct 31, 2017

Motivation for this change

Fix tests after 7ce8483 updated pip-tools from 1.9.0 to 1.10.1. The tests now require that VIRTUAL_ENV is set, but do not care about its value or if they run inside virtualenv. All four deselected tests pass without sandbox.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej orivej requested a review from FRidh as a code owner October 31, 2017 21:51
@orivej orivej changed the title pip-tools: disable tests pip-tools: update tests for 1.9.0 -> 1.10.1 Oct 31, 2017
@orivej orivej merged commit b51aa7b into NixOS:master Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@orivej @GrahamcOfBorg