Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opencv3: fix on darwin #31055

Closed
wants to merge 1 commit into from
Closed

opencv3: fix on darwin #31055

wants to merge 1 commit into from

Conversation

acowley
Copy link
Contributor

@acowley acowley commented Oct 31, 2017

Motivation for this change

Building OpenCV 3.3 (as opposed to the previous nixpkgs release of 3.2) required a few changes to build for me.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Oct 31, 2017
@basvandijk
Copy link
Member

FYI I was able to build #30946 on x86_64-darwin.

@acowley acowley closed this Oct 31, 2017
@acowley
Copy link
Contributor Author

acowley commented Oct 31, 2017

Thanks @basvandijk! I use several options in the configuration, so I’m used to having to build from source. When I saw that hydra was failing, I applied my local changes. But if none are needed, that’s even easier!

@basvandijk
Copy link
Member

@acowley I build opencv3 using the following options on darwin:

nix-build -E '(import ./. {}).opencv3.override {enableIpp = true; enableContrib = true;}' --option build-use-sandbox true

Which options did you use?

Maybe your changes are still needed for the options you enabled.

@acowley
Copy link
Contributor Author

acowley commented Nov 4, 2017

Yes, I will follow up on that. The main flags I use that I can remember off the top of my head are those that enable contrib, ffmpeg, and python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@acowley @basvandijk @LnL7