Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documenting the fact that overrideAttr doesn't work on recursive sets #31698

Closed
wants to merge 1 commit into from
Closed

Documenting the fact that overrideAttr doesn't work on recursive sets #31698

wants to merge 1 commit into from

Conversation

P-E-Meunier
Copy link
Contributor

This was not documented and caused me to waste hours on it.

Also, giving an alternative solution, like this PR does, doesn't hurt.

@danbst
Copy link
Contributor

danbst commented Nov 20, 2017

I'd say +1 for this note, but I have another example, which doesn't invoke creating custom attributes.

If you do .overrideAttrs (old: { version = "x.x.x"; }) it won't trigger an error, but also won't change package version, name and sources. You have to override both name and src to make it work (in most cases, but not all).

So, it's not something specific to "recursive sets", even let-binded variables used in mkDerivation will behave same.

@mmahut
Copy link
Member

mmahut commented Aug 3, 2019

What is the status of this pull request?

@mmahut
Copy link
Member

mmahut commented Aug 19, 2019

Closing due to lack of activity, feel free to reopen this if needed.

@mmahut mmahut closed this Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: developer experience 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@P-E-Meunier @danbst @mmahut @c0bw3b @GrahamcOfBorg