Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zotero: 4.0.29 -> 5.0.25 #31699

Merged
merged 2 commits into from Nov 16, 2017
Merged

zotero: 4.0.29 -> 5.0.25 #31699

merged 2 commits into from Nov 16, 2017

Conversation

timor
Copy link
Member

@timor timor commented Nov 15, 2017

This uses buildFHSUserenv. The source installation probably does not work until
node2nix supports nodejs-8.x.

Motivation for this change

Zotero does not come bundled with newer firefox versions anymore, only standalone is supported.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@timor
Copy link
Member Author

timor commented Nov 15, 2017

See also #31479

@timor
zotero: 4.0.29 -> 5.0.25
e1a797e 
This uses buildFHSUserenv.  The source installation probably does not work until
node2nix supports nodejs-8.x.
@c0bw3b
Copy link
Contributor

c0bw3b commented Nov 15, 2017

This would also close #10355 presumably

@orivej
Copy link
Contributor

orivej commented Nov 15, 2017

This package should also install a menu entry (a desktop file) and icons (they are available in data/chrome/icons/default/). @timor Would you do this?

@timor
Copy link
Member Author

timor commented Nov 16, 2017

@c0bw3b I have not tested all the things mentioned in #10355

@orivej Haven't done this before, is there a good example package? Also, how to test that, I am not using a desktop environment?

@orivej
Copy link
Contributor

orivej commented Nov 16, 2017

I don't know how to test this without a desktop environment, so I've pushed a commit with the desktop entry.

@orivej orivej merged commit 9939032 into NixOS:master Nov 16, 2017
@devhell
Copy link
Contributor

devhell commented Nov 16, 2017

This is amazing, thank you @timor! 🍻

@timor timor deleted the zotero-5 branch November 17, 2017 13:43
@c0bw3b c0bw3b mentioned this pull request Nov 20, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@timor @c0bw3b @orivej @devhell @GrahamcOfBorg