pythonPackages.mpi4py: 2.0.0 -> 3.0.0 #31695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that Python 3 already is supported for 2.0.0. Maybe that should be backported? |
Tests run with sandboxing enabled again and we can remove some of the fixes as they aren't necessary anymore. PyPy and Python 3 are also supported.
Moredread
force-pushed
the
mpi4py-3.0.0
branch
from
7945130
to
fb8ff9e
Compare
|
@GrahamcOfBorg build pythonPackages.mpi4py |
There was a problem hiding this comment.
Failure for system: x86_64-darwin
/nix/store/vgapfdgsbh4znd2c396hk2c27ggvs0rz-mpi4py-3.0.0.tar.gz.drv
/nix/store/bgvd1bswbklb1claf4s831szznqk07nc-python2.7-mpi4py-3.0.0.drv
these paths will be fetched (5.44 MiB download, 16.02 MiB unpacked):
/nix/store/7ikakkxayhv0p6c7rv276q6sbz2kpa07-openmpi-1.10.7
fetching path ‘/nix/store/7ikakkxayhv0p6c7rv276q6sbz2kpa07-openmpi-1.10.7’...
unable to connect to ‘mac1’
unable to open SSH connection to ‘mac1’, trying other available machines...
building path(s) ‘/nix/store/l3xa1p4mzsh0nd52g8lhxaj4ybc90znp-mpi4py-3.0.0.tar.gz’
killing process 8776
error: a ‘x86_64-darwin’ is required to build ‘/nix/store/vgapfdgsbh4znd2c396hk2c27ggvs0rz-mpi4py-3.0.0.tar.gz.drv’, but I am a ‘x86_64-linux’
GrahamcOfBorg
approved these changes
Nov 15, 2017
There was a problem hiding this comment.
Success for system: x86_64-linux
[0@localhost] Python 2.7 (/nix/store/f6pmgza1hha574hm76p98mc2s6gsn3y8-python-2.7.14/bin/python2.7)
[0@localhost] MPI 3.0 (Open MPI 1.10.7)
[0@localhost] mpi4py 3.0.0 (build/lib.linux-x86_64-2.7/mpi4py)
....s.........................................................................................................................................................................................................................................................s.s.s.s.........................................ssssssssssssssssssssssss..........................................................ss...................................................................ssssssssssss..................................s.ss.........s............ssss............................................................................................................................................................s.s..........ssssssssssssss........................ssssss...........ssssss......s...s................................................................................................................................ss......s...ss..............................................s..s...s..s...ssssssssssssssssssssssssssssssssssssssss..........................................................................................................................
----------------------------------------------------------------------
Ran 1134 tests in 13.042s
OK (skipped=130)
warning: SQLite database is busy
/nix/store/j8z8sh11rgfc44laym4vplhg0zax5mn5-python2.7-mpi4py-3.0.0
|
Looks good, merging! @FRidh do you think 17.09 should enable python 3 for this package based on @Moredread comments above? |
|
Supporting more on 17.09 than now is fine as long as it doesn't break anything. It just requires someone making the changes and testing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests run with sandboxing enabled again and we can remove some of the fixes as
they aren't necessary anymore.
PyPy and Python 3 are also supported.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)