Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qutebrowser: 1.0.2 -> 1.0.3 #31299

Merged
merged 1 commit into from Nov 6, 2017
Merged

qutebrowser: 1.0.2 -> 1.0.3 #31299

merged 1 commit into from Nov 6, 2017

Conversation

timokau
Copy link
Member

@timokau timokau commented Nov 6, 2017

Motivation for this change

Package update

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej
Copy link
Contributor

orivej commented Nov 6, 2017

Could you replace The-Compiler with qutebrowser, as the repository has been moved?

@timokau
Copy link
Member Author

timokau commented Nov 6, 2017

Done

version = "1.0.2";
name = "qutebrowser-${version}${fix_postfix}";
fix_postfix = "-1";
version = "1.0.3";
namePrefix = "";

src = fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use fetchFromGitHub instead of fetchurl.

Copy link
Contributor

@orivej orivej Nov 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterhoeg No, this is a release tarball made by the authors of the project, it is not autogenerated by GitHub.

@orivej orivej merged commit 5de8911 into NixOS:master Nov 6, 2017
@timokau timokau deleted the qutebrowser-1.03 branch November 6, 2017 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants