Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LB-239] Fix ListenBrainz devel environment, add psycopg==2.7.3.2 #6

Closed
wants to merge 2 commits into from
Closed

[LB-239] Fix ListenBrainz devel environment, add psycopg==2.7.3.2 #6

wants to merge 2 commits into from

Conversation

jwflory
Copy link
Contributor

@jwflory jwflory commented Nov 11, 2017 •
edited

Summary

Specifies psycopg==2.7.3.2 in the requirements.txt because of a bug in psycopg 2.6.1.

Background

See [LB-239].

Details

I wasn't able to easily test this solution inside of listenbrainz-server, so it would be helpful for @mayhem or @paramsingh to look at this one too. It should work in theory, but I also don't want to break something else.

Edit: Part of the problem is on the first line of the messybrainz-server requirements.txt file.

@brainzbot
Copy link
Member

Can one of the admins verify this patch?

2 similar comments
@brainzbot
Copy link
Member

Can one of the admins verify this patch?

@brainzbot
Copy link
Member

Can one of the admins verify this patch?

This was referenced Nov 11, 2017
Merged
Closed
Merged
Merged
@paramsingh
Copy link
Collaborator

I think LB-239 was more about messybrainz and listenbrainz dependencies than brainzutils?

@jwflory
Copy link
Contributor Author

jwflory commented Nov 11, 2017

@paramsingh I updated my master branch and tried initializing one of the databases…

docker-compose -f docker/docker-compose.yml -p listenbrainz run --rm web python3 manage.py init_db --create-db

…but the development environment still fails to start.

Step 14/26 : RUN pip3 install -r requirements.txt
 ---> Running in 5b9a04657cb6
Collecting git+https://github.com/metabrainz/brainzutils-python.git@v1.1.0 (from -r requirements.txt (line 1))
  Cloning https://github.com/metabrainz/brainzutils-python.git (to v1.1.0) to /tmp/pip-eplmgjl8-build
[…]
Collecting psycopg2==2.6.1 (from -r requirements.txt (line 13))
  Downloading psycopg2-2.6.1.tar.gz (371kB)
    Complete output from command python setup.py egg_info:
    running egg_info
    creating pip-egg-info/psycopg2.egg-info
    writing pip-egg-info/psycopg2.egg-info/PKG-INFO
    writing dependency_links to pip-egg-info/psycopg2.egg-info/dependency_links.txt
    writing top-level names to pip-egg-info/psycopg2.egg-info/top_level.txt
    writing manifest file 'pip-egg-info/psycopg2.egg-info/SOURCES.txt'
    Error: could not determine PostgreSQL version from '10.1'
    
    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-d83fvcht/psycopg2/
ERROR: Service 'web' failed to build: The command '/bin/sh -c pip3 install -r requirements.txt' returned a non-zero code: 1

@jwflory
Copy link
Contributor Author

jwflory commented Nov 11, 2017

Disregard the above comment. @paramsingh had me run this command and everything is working now.

docker-compose -f docker/docker-compose.yml -p listenbrainz build --no-cache

Now, the question is if we still want to merge this or not to be explicit in the psycopg dependency.

@paramsingh
Copy link
Collaborator

There isn't a psycopg dependency here, as far as I know. It is a dependency of LB and MessyBrainz, I think.

@jwflory jwflory mentioned this pull request Nov 11, 2017
Merged
@jwflory
Copy link
Contributor Author

jwflory commented Nov 11, 2017

Then yeah, this can be closed. 😄

@jwflory jwflory closed this Nov 11, 2017
@jwflory jwflory deleted the fix/pip-psycopg-2.7.3.2 branch November 11, 2017 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jwflory @brainzbot @paramsingh