pythonPackages.yowsup: disable python2 build #31519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll run |
|
FRidh
requested changes
Nov 11, 2017
| @@ -1,10 +1,14 @@ | |||
| { buildPythonPackage, stdenv, fetchFromGitHub, six, python-axolotl, pytest }: | |||
| { buildPythonPackage, stdenv, fetchFromGitHub, six, python-axolotl, pytest | |||
| , disabled | |||
There was a problem hiding this comment.
don't add it as parameter. Just add it directly to the call to buildPythonPackage.
|
|
||
| buildPythonPackage rec { | ||
| name = "${pname}-${version}"; | ||
| pname = "yowsup"; | ||
| version = "2.5.2"; | ||
|
|
||
| inherit disabled; |
There was a problem hiding this comment.
...and please add a reason for disabling a package.
I'm not exactly sure why, but it seems as the python2 build of yowsup is breaking. see tgalal/yowsup#2325 It seems to be recommended to use python3 for building and disable the usage of python2 which fixed the build.
|
@FRidh I linked the issue in a comment above the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I'm not exactly sure why, but it seems as the python2 build
of yowsup is breaking.
see tgalal/yowsup#2325
It seems to be recommended to use python3 for building and disable
the usage of python2 which fixed the build.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)