Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php: Fix php pcre symbol collissions #31525

Closed
wants to merge 1 commit into from
Closed

php: Fix php pcre symbol collissions #31525

wants to merge 1 commit into from

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Nov 11, 2017 •
edited

Motivation for this change

Fixes #31451 #31499

Things done

Tested using https://gist.github.com/srhb/2d9f5354cdf16c96ec3356f4c5383303

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor Author

srhb commented Nov 11, 2017

Alternative candidate for the fix: #31526

@srhb srhb mentioned this pull request Nov 11, 2017
Merged
8 tasks
@srhb
Copy link
Contributor Author

srhb commented Nov 13, 2017

Deprecated by #31526

@srhb srhb closed this Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@srhb @GrahamcOfBorg