Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fonts: fix fontconfig.localConf when used with penultimate #31504

Merged
merged 1 commit into from
Nov 15, 2017
Merged

fonts: fix fontconfig.localConf when used with penultimate #31504

merged 1 commit into from
Nov 15, 2017
+8 −0

Conversation

benley
Copy link
Member

@benley benley commented Nov 10, 2017

Fixes #31500

Motivation for this change

This makes the fonts.fontconfig.localConf option work as expected when fonts.fontconfig.penultimate is enabled.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@benley benley added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 10, 2017
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 10, 2017
@ttuegel ttuegel merged commit dd5e6bc into NixOS:master Nov 15, 2017
@benley benley deleted the fontconfig-localconf branch November 15, 2017 16:20
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fonts.fontconfig.localConf ignored unless fonts.fontconfig.penultimate is disabled
5 participants
@benley @orivej @samueldr @ttuegel @GrahamcOfBorg