Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xorg.bitmap: init at 1.0.8 #30837

Merged
merged 2 commits into from Nov 29, 2017
Merged

xorg.bitmap: init at 1.0.8 #30837

merged 2 commits into from Nov 29, 2017

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Oct 26, 2017

Motivation for this change

I wanted to make old-school desktop backgrounds

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s)
  • Tested compilation of all pkgs that depend on this change (none)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.
Issues

The application is working but the layout seems broken. I'm not sure how it's supposed to look but the buttons are missing labels/icons and clicking on the save buttons yields

Warning: MenuButton:  Could not find menu widget named menu.

Is it missing some dependency?

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 17, 2017 •
edited

Found the issue:

access("/nix/store/4jx7q3dgpwy2j6k6rpiiblsyvcb7nb2x-libXt-1.1.5/etc/X11/en_US.UTF-8/app-defaults/Bitmap", R_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/4jx7q3dgpwy2j6k6rpiiblsyvcb7nb2x-libXt-1.1.5/etc/X11/en/app-defaults/Bitmap", R_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/4jx7q3dgpwy2j6k6rpiiblsyvcb7nb2x-libXt-1.1.5/etc/X11/app-defaults/Bitmap", R_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/4jx7q3dgpwy2j6k6rpiiblsyvcb7nb2x-libXt-1.1.5/etc/X11/en_US.UTF-8/app-defaults/Bitmap", R_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/4jx7q3dgpwy2j6k6rpiiblsyvcb7nb2x-libXt-1.1.5/etc/X11/en/app-defaults/Bitmap", R_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/4jx7q3dgpwy2j6k6rpiiblsyvcb7nb2x-libXt-1.1.5/etc/X11/app-defaults/Bitmap", R_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/4jx7q3dgpwy2j6k6rpiiblsyvcb7nb2x-libXt-1.1.5/share/X11/en_US.UTF-8/app-defaults/Bitmap", R_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/4jx7q3dgpwy2j6k6rpiiblsyvcb7nb2x-libXt-1.1.5/share/X11/en/app-defaults/Bitmap", R_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/4jx7q3dgpwy2j6k6rpiiblsyvcb7nb2x-libXt-1.1.5/share/X11/app-defaults/Bitmap", R_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/4jx7q3dgpwy2j6k6rpiiblsyvcb7nb2x-libXt-1.1.5/share/X11/en_US.UTF-8/app-defaults/Bitmap", R_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/4jx7q3dgpwy2j6k6rpiiblsyvcb7nb2x-libXt-1.1.5/share/X11/en/app-defaults/Bitmap", R_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/4jx7q3dgpwy2j6k6rpiiblsyvcb7nb2x-libXt-1.1.5/share/X11/app-defaults/Bitmap", R_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/4jx7q3dgpwy2j6k6rpiiblsyvcb7nb2x-libXt-1.1.5/lib/X11/en_US.UTF-8/app-defaults/Bitmap", R_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/4jx7q3dgpwy2j6k6rpiiblsyvcb7nb2x-libXt-1.1.5/lib/X11/en/app-defaults/Bitmap", R_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/4jx7q3dgpwy2j6k6rpiiblsyvcb7nb2x-libXt-1.1.5/lib/X11/app-defaults/Bitmap", R_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/4jx7q3dgpwy2j6k6rpiiblsyvcb7nb2x-libXt-1.1.5/lib/X11/en_US.UTF-8/app-defaults/Bitmap", R_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/4jx7q3dgpwy2j6k6rpiiblsyvcb7nb2x-libXt-1.1.5/lib/X11/en/app-defaults/Bitmap", R_OK) = -1 ENOENT (No such file or directory)
access("/nix/store/4jx7q3dgpwy2j6k6rpiiblsyvcb7nb2x-libXt-1.1.5/lib/X11/app-defaults/Bitmap", R_OK) = -1 ENOENT (No such file or directory)

Bitmap is taking the appdefaultdir variable from libXt. Also it seems to ignore --with-appdefaultdir=

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 17, 2017

@vcunat Can you help me?

@vcunat
Copy link
Member

vcunat commented Nov 20, 2017

I don't know; I would look into their makefiles, looking if its overridable by passing a make variable or patching it in the worst case...

@orivej
Copy link
Contributor

orivej commented Nov 29, 2017 •
edited

I have fixed this based on Eelco's response in https://nixos.org/nix-dev/2009-December/003656.html .

Bitmap has two color schemes, monochrome and colored. Since monochrome is the default, I have provided the colored version in the bitmap-color executable.

You may be also interested in another pixel editor called Aseprite.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Nov 29, 2017

@orivej Thank you!

@orivej orivej merged commit 31a96a3 into NixOS:master Nov 29, 2017
@rnhmjoj rnhmjoj deleted the bitmap branch January 22, 2018 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rnhmjoj @vcunat @orivej @GrahamcOfBorg