Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-trezor: Move mnemonic dependency to propagatedBuildInputs #30838

Closed
wants to merge 1 commit into from
Closed

python-trezor: Move mnemonic dependency to propagatedBuildInputs #30838

wants to merge 1 commit into from

Conversation

clefru
Copy link
Contributor

@clefru clefru commented Oct 26, 2017

Motivation for this change

Fixes #30831

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Oct 28, 2017

I will backport #30839 later instead.

@Mic92 Mic92 closed this Oct 28, 2017
@clefru
Copy link
Contributor Author

clefru commented Nov 21, 2017

@Mic92: Not sure if I understood you correctly but this PR is the backport of #30839 on the release-17.09 branch. At least I can't see it fixed in any other way on that branch.

@Mic92
Copy link
Member

Mic92 commented Nov 22, 2017

sorry I backported it now: c8df8c8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jb55 jb55 jb55 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clefru @Mic92 @jb55