Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

You get:remove duplicate definition #30855

Closed
wants to merge 5 commits into from
Closed

You get:remove duplicate definition #30855

wants to merge 5 commits into from

Conversation

pasqui23
Copy link
Contributor

@pasqui23 pasqui23 commented Oct 27, 2017 •
edited

Motivation for this change

A duplicate definition of you-get in python-packaages.nix causes every build to fail.This commit removes the second definition

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@pasqui23 pasqui23 requested a review from FRidh as a code owner October 27, 2017 06:24
@adisbladis
Copy link
Member

You have added some extra commits that do not belong in this PR.

@pasqui23 pasqui23 closed this Oct 27, 2017
@pasqui23 pasqui23 deleted the you-get branch October 27, 2017 06:40
@XVilka XVilka mentioned this pull request Nov 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pasqui23 @adisbladis