Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodejs security releases (fixes CVE--2017-14919) #30849

Merged
merged 3 commits into from Oct 27, 2017
Merged

Nodejs security releases (fixes CVE--2017-14919) #30849

merged 3 commits into from Oct 27, 2017

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Oct 27, 2017 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Building it now but takes a while

@fpletz fpletz merged commit f0cea7c into NixOS:master Oct 27, 2017
@fpletz
Copy link
Member

fpletz commented Oct 27, 2017

Thanks!

@adisbladis
Copy link
Member Author

@fpletz Should probably be backported to 17.09.

@fpletz
Copy link
Member

fpletz commented Oct 27, 2017

Yup, already on it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adisbladis @fpletz