Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dpkg: 1.18.24 -> 1.19.0.4 #30854

Merged
merged 2 commits into from Oct 28, 2017
Merged

dpkg: 1.18.24 -> 1.19.0.4 #30854

merged 2 commits into from Oct 28, 2017

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Oct 27, 2017 •
edited

Motivation for this change

Upstream minor release

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

NeQuissimus
NeQuissimus requested changes Oct 27, 2017
View reviewed changes
Copy link
Member

@NeQuissimus NeQuissimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the outputs need but can't find each other:

/nix/store/jazikx4cvas6xld7x3x4vvqpp9jf3nd7-dpkg-1.19.0.4
[nix] ~/nixpkgs pr-30854 λ ./result/bin/dpkg --status
dpkg: error: unable to execute dpkg-query (dpkg-query): No such file or directory

@adisbladis
Copy link
Member Author

@NeQuissimus I think this was always a problem when accessing binaries through store-paths rather than through nix-shell or in systemPackages that sets up $PATH.
I'll see what we can do about patching the external process calls.

@adisbladis
Copy link
Member Author

Luckily all of these commands are defined in a header file so it was pretty easy to patch :)

@Mic92 Mic92 merged commit b972139 into NixOS:master Oct 28, 2017
@NeQuissimus
Copy link
Member

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adisbladis @NeQuissimus @Mic92