Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-trezor: Move mnemonic dependency to propagatedBuildInputs #30839

Merged
merged 5 commits into from Nov 7, 2017
Merged

python-trezor: Move mnemonic dependency to propagatedBuildInputs #30839

merged 5 commits into from Nov 7, 2017

Conversation

clefru
Copy link
Contributor

@clefru clefru commented Oct 26, 2017 •
edited

Motivation for this change

Fixes #30831

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 mentioned this pull request Oct 28, 2017
Closed
8 tasks
@orivej
Copy link
Contributor

orivej commented Nov 6, 2017

@Mic92 Would you continue with this PR?

@clefru clefru requested a review from FRidh as a code owner November 7, 2017 18:00
@Mic92 Mic92 merged commit 6c27c7e into NixOS:master Nov 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jb55 jb55 jb55 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@clefru @orivej @jb55 @Mic92 @GrahamcOfBorg